linux-kernel - Re: [PATCH RESEND] fpga: dfl: omit unneeded casts of u64 values for dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Apr 2024 19:14:58 +0000
From: "Colberg, Peter" <peter.colberg@...el.com>
To: "yilun.xu@...ux.intel.com" <yilun.xu@...ux.intel.com>
CC: "Xu, Yilun" <yilun.xu@...el.com>, "linux-fpga@...r.kernel.org"
	<linux-fpga@...r.kernel.org>, "mdf@...nel.org" <mdf@...nel.org>,
	"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>, "Wu,
 Hao" <hao.wu@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "russ.weight@...ux.dev"
	<russ.weight@...ux.dev>, "Pagani, Marco" <marpagan@...hat.com>, "Rix, Tom"
	<trix@...hat.com>, "matthew.gerlach@...ux.intel.com"
	<matthew.gerlach@...ux.intel.com>
Subject: Re: [PATCH RESEND] fpga: dfl: omit unneeded casts of u64 values for
 dev_dbg()

On Fri, 2024-04-19 at 17:05 +0800, Xu Yilun wrote:
> On Thu, Apr 18, 2024 at 09:30:48PM +0000, Colberg, Peter wrote:
> > On Tue, 2024-04-02 at 11:29 +0800, Xu Yilun wrote:
> > > On Thu, Mar 28, 2024 at 08:04:29PM -0400, Peter Colberg wrote:
> > > > Omit unneeded casts of u64 values to unsigned long long for use with
> > > > printk() format specifier %llx. Unlike user space, the kernel defines
> > > > u64 as unsigned long long for all architectures; see commit 2a7930bd77fe
> > > > ("Documentation/printk-formats.txt: No casts needed for u64/s64").
> > > 
> > > The change is OK. But I suggest just delete the unnecessary dev_dbg()
> > > since now people normally don't want these "Hello, I'm here!" info.
> > 
> > How would you like me to proceed? Should I remove dev_dbg() in all DFL
> 
> I think do for all DFL would be enough. Usually you want something to
> follow up and do the related clean up in advance.

Thanks Yilun. I will include the removals of dev_dbg() in a revision of
the SRIOV patch series, since it touches many DFL modules as well.

Thanks,
Peter