linux-kernel - Re: [PATCH v3 00/24] gpio: rework locking and object life-time control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACMJSeuGu4nCVsbSnTrJwEdU+RF0BKHbzS7A9Cf2CiM_stJPzg@mail.gmail.com>
Date: Fri, 19 Apr 2024 23:29:16 +0200
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: brgl@...ev.pl, andriy.shevchenko@...ux.intel.com, elder@...aro.org, 
	geert+renesas@...der.be, linus.walleij@...aro.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, paulmck@...nel.org, warthog618@...il.com, 
	wsa@...-dreams.de
Subject: Re: [PATCH v3 00/24] gpio: rework locking and object life-time control

On Fri, 19 Apr 2024 at 09:04, Jiawen Wu <jiawenwu@...stnetic.com> wrote:
>
> Hi Bartosz Golaszewski,
>
> I ran into a kernel crash problem when I pull the latest net-next.git, and
> finally it was found that is caused by this patch series merged.
>
> The kernel crashed because I got gpio=0 when I called irq_find_mapping()
> and then struct irq_data *d=null, as my driver describes:
>
>         int gpio = irq_find_mapping(gc->irq.domain, hwirq);
>         struct irq_data *d = irq_get_irq_data(gpio);
>
>         txgbe_gpio_irq_ack(d);
>
> The deeper positioning is this line in __irq_resolve_mapping().
>
>         data = rcu_dereference(domain->revmap[hwirq]);
>
> So, is it the addition of SRCU infrastructure that causes this issue?
>

This is irq-specific RCU that I did not add in the GPIO series. Please
provide us with more information. Bisect to the exact commit causing
the issue and post the kernel log (we don't know what kind of crash
you trigger and what the stack trace is).

Bart