linux-kernel - Re: [PATCHv2 next] ptp: update gettimex64 to provide ts optionally in mono-raw base.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF2d9jhrC0uywa3NJLqgXGKauTEkGhK4A0YWorw4BV-fa5hbmg@mail.gmail.com>
Date: Fri, 19 Apr 2024 15:14:19 -0700
From: Mahesh Bandewar (महेश बंडेवार) <maheshb@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Netdev <netdev@...r.kernel.org>, Linux <linux-kernel@...r.kernel.org>, 
	David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, 
	Richard Cochran <richardcochran@...il.com>, Arnd Bergmann <arnd@...db.de>, 
	Sagi Maimon <maimon.sagi@...il.com>, Jonathan Corbet <corbet@....net>, John Stultz <jstultz@...gle.com>, 
	Mahesh Bandewar <mahesh@...dewar.net>
Subject: Re: [PATCHv2 next] ptp: update gettimex64 to provide ts optionally in
 mono-raw base.

On Thu, Apr 18, 2024 at 6:55 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 17 Apr 2024 21:27:06 -0700 Mahesh Bandewar wrote:
> > --- a/include/uapi/linux/ptp_clock.h
> > +++ b/include/uapi/linux/ptp_clock.h
> > @@ -157,7 +157,12 @@ struct ptp_sys_offset {
> >
> >  struct ptp_sys_offset_extended {
> >       unsigned int n_samples; /* Desired number of measurements. */
> > -     unsigned int rsv[3];    /* Reserved for future use. */
> > +     /* The original implementation provided timestamps (always) in
> > +      * REALTIME clock-base. Since CLOCK_REALTIME is 0, adding
> > +      * clockid doesn't break backward compatibility.
> > +      */
> > +     clockid_t clockid;      /* One of the supported clock-ids */
> > +     unsigned int rsv[2];    /* Reserved for future use. */
>
> This suffers from a moderate inability to build:
>
> usr/include/linux/ptp_clock.h:164:2: error: unknown type name 'clockid_t'
>   164 |         clockid_t clockid;      /* One of the supported clock-ids */
>       |         ^
Hmm, my bad, it didn't fail while I was testing/building. I should
watch the bot checks more carefully :(
I'll fix it in the next revision.
> --
> pw-bot: cr