linux-kernel - RE: [PATCH v3 1/2] caam: init-clk based on caam-page0-access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Apr 2024 05:29:06 +0000
From: Pankaj Gupta <pankaj.gupta@....com>
To: Horia Geanta <horia.geanta@....com>, Gaurav Jain <gaurav.jain@....com>,
	Varun Sethi <V.Sethi@....com>, "herbert@...dor.apana.org.au"
	<herbert@...dor.apana.org.au>, "davem@...emloft.net" <davem@...emloft.net>,
	Iuliana Prodan <iuliana.prodan@....com>, "linux-crypto@...r.kernel.org"
	<linux-crypto@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH v3 1/2] caam: init-clk based on caam-page0-access



> -----Original Message-----
> From: Horia Geanta <horia.geanta@....com>
> Sent: Thursday, April 18, 2024 8:20 PM
> To: Pankaj Gupta <pankaj.gupta@....com>; Gaurav Jain
> <gaurav.jain@....com>; Varun Sethi <V.Sethi@....com>;
> herbert@...dor.apana.org.au; davem@...emloft.net; Iuliana Prodan
> <iuliana.prodan@....com>; linux-crypto@...r.kernel.org; linux-
> kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH v3 1/2] caam: init-clk based on caam-page0-access
> 
> On 4/16/2024 8:35 AM, Pankaj Gupta wrote:
> > CAAM clock initializat is done based on the basis of soc specific
> 	     ^ initialization
> 
> > @@ -889,17 +895,25 @@ static int caam_probe(struct platform_device
> *pdev)
> >
> >  		reg_access = !ctrlpriv->optee_en;
> >
> > -		if (!imx_soc_match->data) {
> > +		if (imx_soc_match->data) {
> This is obviously incorrect.
[Accepted] 
> 
> >  			dev_err(dev, "No clock data provided for i.MX SoC");
> >  			return -EINVAL;
> >  		}
> 
> Regards,
> Horia