linux-kernel - Re: [PATCH] i2c: mpc: Removal of of_node_put with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87plulakak.fsf@mail.lhotse>
Date: Fri, 19 Apr 2024 17:22:43 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Chris Packham <Chris.Packham@...iedtelesis.co.nz>, Andi Shyti
 <andi.shyti@...nel.org>, Abhinav Jain <jain.abhinav177@...il.com>
Cc: "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "skhan@...uxfoundation.org" <skhan@...uxfoundation.org>,
 "javier.carrasco.cruz@...il.com" <javier.carrasco.cruz@...il.com>, Julia
 Lawall <julia.lawall@...ia.fr>, "linuxppc-dev@...ts.ozlabs.org"
 <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto
 cleanup

Chris Packham <Chris.Packham@...iedtelesis.co.nz> writes:
> On 16/04/24 08:54, Andi Shyti wrote:
>> Hi Abhinav,
>>
>>>   	/* Enable I2C interrupts for mpc5121 */
>>> -	node_ctrl = of_find_compatible_node(NULL, NULL,
>>> -					    "fsl,mpc5121-i2c-ctrl");
>>> +	struct device_node *node_ctrl __free(device_node) =
>> How have you tested this?
>
> I'm not sure I know anyone that still has a mpc5121. Maybe someone on 
> linuxppc-dev?

Not that I know of.

The driver loads on my T4240, but doesn't hit the right paths to test
this patch.

No objection to it being merged though.

cheers