linux-kernel - Re: [PATCH v2] fpga: dfl: remove unused function is_dfl_feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZiIipqA6PdZIslfR@yilunxu-OptiPlex-7050>
Date: Fri, 19 Apr 2024 15:52:06 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Peter Colberg <peter.colberg@...el.com>
Cc: Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
	Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>,
	linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
	Russ Weight <russ.weight@...ux.dev>,
	Marco Pagani <marpagan@...hat.com>,
	Matthew Gerlach <matthew.gerlach@...ux.intel.com>
Subject: Re: [PATCH v2] fpga: dfl: remove unused function
 is_dfl_feature_present

On Mon, Apr 15, 2024 at 07:57:43PM -0400, Peter Colberg wrote:
> The function is_dfl_feature_present was added but never used.
                                    ^

Function reference should use the format "function_name()", I fixed it
in place.

Applied to for-next.

> 
> Fixes: 5b57d02a2f94 ("fpga: dfl: add feature device infrastructure")
> Signed-off-by: Peter Colberg <peter.colberg@...el.com>
> Reviewed-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> ---
> v2:
> - Do not wrap commit reference and move to Fixes: tag.
> ---
>  drivers/fpga/dfl.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 1d724a28f00a..5063d73b0d82 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -437,11 +437,6 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
>  	return NULL;
>  }
>  
> -static inline bool is_dfl_feature_present(struct device *dev, u16 id)
> -{
> -	return !!dfl_get_feature_ioaddr_by_id(dev, id);
> -}
> -
>  static inline
>  struct device *dfl_fpga_pdata_to_parent(struct dfl_feature_platform_data *pdata)
>  {
> -- 
> 2.44.0
> 
>