linux-kernel - Re: [PATCH v2 0/2] sched/eevdf: Minor fixes for reweight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240419080225.GA6345@noisy.programming.kicks-ass.net>
Date: Fri, 19 Apr 2024 10:02:25 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Chen Yu <yu.c.chen@...el.com>
Cc: Tianchen Ding <dtcccc@...ux.alibaba.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>, Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Daniel Bristot de Oliveira <bristot@...hat.com>,
	Valentin Schneider <vschneid@...hat.com>,
	Abel Wu <wuyun.abel@...edance.com>
Subject: Re: [PATCH v2 0/2] sched/eevdf: Minor fixes for reweight_entity()

On Fri, Apr 19, 2024 at 03:27:30PM +0800, Chen Yu wrote:
> On 2024-03-06 at 10:21:31 +0800, Tianchen Ding wrote:
> > According to the discussion in [1], fix a calculation bug in
> > reweight_entity().
> > 
> > [1] https://lore.kernel.org/all/59585184-d13d-46e0-8d68-42838e97a702@bytedance.com/
> > 
> > v2:
> > Add fixes tag to the 1st patch.
> > 
> > v1: https://lore.kernel.org/all/20240304030042.2690-1-dtcccc@linux.alibaba.com/
> > 
> > Tianchen Ding (2):
> >   sched/eevdf: Always update V if se->on_rq when reweighting
> >   sched/eevdf: Fix miscalculation in reweight_entity() when se is not
> >     curr
> > 
> >  kernel/sched/fair.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > -- 
> > 2.39.3
> >
> 
> Applied this patch set on top of the reweight_entity fix at
> https://lore.kernel.org/lkml/ZiEaKOQwiNEglYtS@chenyu5-mobl2/
> it has passed 100 cycles of trinity test without any issue.
> 
> For the whole serie,
> 
> Tested-by: Chen Yu <yu.c.chen@...el.com>

OK, grabbed these patches (and made some minor edits), now let me go
stare at that other thread again.