linux-kernel - Re: [PATCH v3 0/2] crypto: ecdh & ecc: Fix private key byte ordering issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15623fb6-1ecc-4e6a-872b-07172a3674aa@redhat.com>
Date: Fri, 19 Apr 2024 12:49:54 +0200
From: Hubert Kario <hkario@...hat.com>
To: Stefan Berger <stefanb@...ux.ibm.com>
Cc: <linux-crypto@...r.kernel.org>,
 <herbert@...dor.apana.org.au>,
 <davem@...emloft.net>,
 <linux-kernel@...r.kernel.org>,
 <jarkko@...nel.org>,
 <ardb@...nel.org>,
 <git@...sn.com>,
 <simo@...hat.com>
Subject: Re: [PATCH v3 0/2] crypto: ecdh & ecc: Fix private key byte ordering issues

Both patches look good to me.

On Thursday, 18 April 2024 17:24:43 CEST, Stefan Berger wrote:
> The 1st patch fixes a byte ordering issue where ctx->private_key is
> currently passed to ecc_is_key_valid but the key is in reverse byte order.
> To solve this issue it introduces the variable 'priv', that is already used
> throughout the ecc and ecdh code bases for a private key in proper byte
> order, and calls ecc_is_key_valid with 'priv'. Note that ecc_gen_privkey
> also calls __ecc_is_key_valid with 'priv' already.
>
> The 2nd patch gets rid of the 'priv' variable wherever it is used to hold
> a private key (byte-swapped initialized from ctx->private_key) in proper
> byte order and uses ctx->private_key directly that is now initialized in
> proper byte order.
>
> Regards,
>   Stefan
>
> v3:
>   - Added Jarkko's A-b tag
>   - Expanded on the description of changes to ecc_gen_privkey (2/2)
>
> v2:
>   - Added missing zeroizing of priv variable (1/2)
>   - Improved patch description (2/2)
>
>
>
>
> Stefan Berger (2):
>   crypto: ecdh - Pass private key in proper byte order to check valid
>     key
>   crypto: ecdh & ecc - Initialize ctx->private_key in proper byte order
>
>  crypto/ecc.c                  | 29 ++++++++++-------------------
>  crypto/ecdh.c                 |  9 ++++++---
>  include/crypto/internal/ecc.h |  3 ++-
>  3 files changed, 18 insertions(+), 23 deletions(-)
>

-- 
Regards,
Hubert Kario
Principal Quality Engineer, RHEL Crypto team
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkyňova 115, 612 00, Brno, Czech Republic