linux-kernel - Re: [PATCH] gpio: tegra186: Fix tegra186_gpio_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Apr 2024 13:40:33 +0200
From: "Thierry Reding" <thierry.reding@...il.com>
To: "Prathamesh Shete" <pshete@...dia.com>, <linus.walleij@...aro.org>,
 <brgl@...ev.pl>, <jonathanh@...dia.com>, <treding@...dia.com>,
 <linux-gpio@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Cc: <mochs@...dia.com>, <csoto@...dia.com>, <jamien@...dia.com>,
 <smangipudi@...dia.com>
Subject: Re: [PATCH] gpio: tegra186: Fix tegra186_gpio_is_accessible() check

On Tue Apr 16, 2024 at 2:35 PM CEST, Prathamesh Shete wrote:
> The controller has several register bits describing access control
> information for a given GPIO pin. When SCR_SEC_[R|W]EN is unset, it
> means we have full read/write access to all the registers for given GPIO
> pin. When SCR_SEC[R|W]EN is set, it means we need to further check the
> accompanying SCR_SEC_G1[R|W] bit to determine read/write access to all
> the registers for given GPIO pin.
>
> This check was previously declaring that a GPIO pin was accessible
> only if either of the following conditions were met:
>
>   - SCR_SEC_REN + SCR_SEC_WEN both set
>
>     or
>
>   - SCR_SEC_REN + SCR_SEC_WEN both set and
>     SCR_SEC_G1R + SCR_SEC_G1W both set
>
> Update the check to properly handle cases where only one of
> SCR_SEC_REN or SCR_SEC_WEN is set.
>
> Fixes: b2b56a163230 ("gpio: tegra186: Check GPIO pin permission before access.")
> Signed-off-by: Prathamesh Shete <pshete@...dia.com>
> ---
>  drivers/gpio/gpio-tegra186.c | 22 ++++++++++++++--------
>  1 file changed, 14 insertions(+), 8 deletions(-)

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)