[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240418185524.18801983@kernel.org>
Date: Thu, 18 Apr 2024 18:55:24 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mahesh Bandewar <maheshb@...gle.com>
Cc: Netdev <netdev@...r.kernel.org>, Linux <linux-kernel@...r.kernel.org>,
David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
Richard Cochran <richardcochran@...il.com>, Arnd Bergmann <arnd@...db.de>,
Sagi Maimon <maimon.sagi@...il.com>, Jonathan Corbet <corbet@....net>, John
Stultz <jstultz@...gle.com>, Mahesh Bandewar <mahesh@...dewar.net>
Subject: Re: [PATCHv2 next] ptp: update gettimex64 to provide ts optionally
in mono-raw base.
On Wed, 17 Apr 2024 21:27:06 -0700 Mahesh Bandewar wrote:
> --- a/include/uapi/linux/ptp_clock.h
> +++ b/include/uapi/linux/ptp_clock.h
> @@ -157,7 +157,12 @@ struct ptp_sys_offset {
>
> struct ptp_sys_offset_extended {
> unsigned int n_samples; /* Desired number of measurements. */
> - unsigned int rsv[3]; /* Reserved for future use. */
> + /* The original implementation provided timestamps (always) in
> + * REALTIME clock-base. Since CLOCK_REALTIME is 0, adding
> + * clockid doesn't break backward compatibility.
> + */
> + clockid_t clockid; /* One of the supported clock-ids */
> + unsigned int rsv[2]; /* Reserved for future use. */
This suffers from a moderate inability to build:
usr/include/linux/ptp_clock.h:164:2: error: unknown type name 'clockid_t'
164 | clockid_t clockid; /* One of the supported clock-ids */
| ^
--
pw-bot: cr
Powered by blists - more mailing lists