linux-kernel - Re: EXTERNAL: Re: [PATCH v2 5/5] arm64: dts: qcom: sa8775p-ride: remove tx-sched-sp property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0c0a324-72a7-4791-90cf-51a2cee59479@kernel.org>
Date: Fri, 19 Apr 2024 15:33:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: FLAVIO SULIGOI <f.suligoi@...m.it>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Giuseppe Cavallaro <peppe.cavallaro@...com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-stm32@...md-mailman.stormreply.com"
 <linux-stm32@...md-mailman.stormreply.com>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: EXTERNAL: Re: [PATCH v2 5/5] arm64: dts: qcom: sa8775p-ride:
 remove tx-sched-sp property

On 19/04/2024 10:45, FLAVIO SULIGOI wrote:
> Hi Krzysztof,
> 
> ...
> 
>> On 18/04/2024 14:28, Flavio Suligoi wrote:
>>> Strict priority for the tx scheduler is by default in Linux driver, so
>>> the tx-sched-sp property was removed in commit aed6864035b1 ("net:
>> stmmac:
>>> platform: Delete a redundant condition branch").
>>>
>>> So we can safely remove this property from this device-tree.
>>>
>>> Signed-off-by: Flavio Suligoi <f.suligoi@...m.it>
>>> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
>>
>> NAK. Not true. Please point me to my review for this patch.
> 
> I'm very sorry for the misunderstanding, I saw your reply in:
> 
> https://lore.kernel.org/netdev/010d67c7-ca71-43fc-a3e3-ec3e5cd8b149@kernel.org/
> 
> and thought it might be okay for all the other patches.

Where was it replied? In patch 5.

Why can't you use b4 for this? It solves the problems.

> 
> Do you want me to resend a v3 version of the patches without the
> "Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>" ?

Yes, you must send new version because you added fake tags. Use b4
trailers to collect tags.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof