linux-kernel - Re: [PATCH v2] blk-iocost: do not WARNING if iocg has already offlined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171353567968.448662.8909505678465861389.b4-ty@kernel.dk>
Date: Fri, 19 Apr 2024 08:07:59 -0600
From: Jens Axboe <axboe@...nel.dk>
To: tj@...nel.org, josef@...icpanda.com, linan666@...weicloud.com
Cc: cgroups@...r.kernel.org, linux-block@...r.kernel.org, 
 linux-kernel@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com, 
 houtao1@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH v2] blk-iocost: do not WARNING if iocg has already
 offlined


On Fri, 19 Apr 2024 17:32:57 +0800, linan666@...weicloud.com wrote:
> In iocg_pay_debt(), warn is triggered if 'active_list' is empty, which
> is intended to confirm iocg is avitve when it has debt. However, warn
> can be triggered during a blkcg or disk is being removed, as
> iocg_waitq_timer_fn() is awakened at that time.
> 
>   WARNING: CPU: 0 PID: 2344971 at block/blk-iocost.c:1402 iocg_pay_debt+0x14c/0x190
>   Call trace:
>   iocg_pay_debt+0x14c/0x190
>   iocg_kick_waitq+0x438/0x4c0
>   iocg_waitq_timer_fn+0xd8/0x130
>   __run_hrtimer+0x144/0x45c
>   __hrtimer_run_queues+0x16c/0x244
>   hrtimer_interrupt+0x2cc/0x7b0
> ps: This issue was got in linux 5.10, but it also exists in the mainline.
> 
> [...]

Applied, thanks!

[1/1] blk-iocost: do not WARNING if iocg has already offlined
      commit: 01bc4fda9ea0a6b52f12326486f07a4910666cf6

Best regards,
-- 
Jens Axboe