linux-kernel - Re: [PATCH v1 02/18] mm/rmap: always inline anon/file rmap duplication of a single PTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5c2ae26-d405-4b0f-8bf6-281abcdb3239@intel.com>
Date: Fri, 19 Apr 2024 10:25:41 +0800
From: "Yin, Fengwei" <fengwei.yin@...el.com>
To: David Hildenbrand <david@...hat.com>, <linux-kernel@...r.kernel.org>
CC: <linux-mm@...ck.org>, <linux-doc@...r.kernel.org>,
	<cgroups@...r.kernel.org>, <linux-sh@...r.kernel.org>,
	<linux-trace-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>, Andrew
 Morton <akpm@...ux-foundation.org>, "Matthew Wilcox (Oracle)"
	<willy@...radead.org>, Peter Xu <peterx@...hat.com>, Ryan Roberts
	<ryan.roberts@....com>, Yang Shi <shy828301@...il.com>, Zi Yan
	<ziy@...dia.com>, Jonathan Corbet <corbet@....net>, Hugh Dickins
	<hughd@...gle.com>, Yoshinori Sato <ysato@...rs.sourceforge.jp>, Rich Felker
	<dalias@...c.org>, John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
	Chris Zankel <chris@...kel.net>, Max Filippov <jcmvbkbc@...il.com>, "Muchun
 Song" <muchun.song@...ux.dev>, Miaohe Lin <linmiaohe@...wei.com>, "Naoya
 Horiguchi" <naoya.horiguchi@....com>, Richard Chang <richardycc@...gle.com>
Subject: Re: [PATCH v1 02/18] mm/rmap: always inline anon/file rmap
 duplication of a single PTE



On 4/10/2024 3:22 AM, David Hildenbrand wrote:
> As we grow the code, the compiler might make stupid decisions and
> unnecessarily degrade fork() performance. Let's make sure to always inline
> functions that operate on a single PTE so the compiler will always
> optimize out the loop and avoid a function call.
> 
> This is a preparation for maintining a total mapcount for large folios.
> 
> Signed-off-by: David Hildenbrand<david@...hat.com>
The patch looks good to me. Just curious: Is this change driven by code
reviewing or performance data profiling? Thanks.


Regards
Yin, Fengwei