lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 19 Apr 2024 17:09:28 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] kbuild: use $(obj)/ instead of $(src)/ for pattern
 rules for %.[cS]

On Tue 16 Apr 2024 21:18:37 GMT, Masahiro Yamada wrote:
> Kbuild conventionally uses $(obj)/ for generated files, and $(src)/ for
> checked-in source files. It is merely a convention without any functional
> difference. In fact, $(obj) and $(src) are exactly the same, as defined
> in scripts/Makefile.build:
> 
>   src := $(obj)
> 
> Before changing the semantics of $(src) in the next commit, this commit
> replaces $(obj)/ with $(src)/ in pattern rules where the prerequisite
> might be a generated file.

thanks.  That's a good idea to split both steps.

> C and assembly files are sometimes generated by tools, so they could
> be either generated files or real sources. The $(obj)/ prefix works
> for both cases with the help of VPATH.
> 
> As mentioned above, $(obj) and $(src) are the same at this point, hence
> this commit has no functional change.
> 
> I did not modify scripts/Makefile.userprogs because there is no use
> case where userspace C files are generated.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ