linux-kernel - Re: [PATCH 0/5] string: Merge separate tests into string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cff8eeeb-ae4c-42b8-8a85-4838959c1e28@gmail.com>
Date: Fri, 19 Apr 2024 17:28:09 +0100
From: Ivan Orlov <ivan.orlov0322@...il.com>
To: Kees Cook <keescook@...omium.org>, Andy Shevchenko <andy@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 0/5] string: Merge separate tests into string_kunit.c

On 4/19/24 15:01, Kees Cook wrote:
> Hi,
> 
> We have a few lone function tests (strscpy and strcat) that are better
> collected into the common string_kunit.c test suite. Perform various
> renamings, merge everything, and clean up after them.
> 
> -Kees
> 
> Kees Cook (5):
>    string: Prepare to merge strscpy_kunit.c into string_kunit.c
>    string: Merge strscpy KUnit tests into string_kunit.c
>    string: Prepare to merge strcat KUnit tests into string_kunit.c
>    string: Merge strcat KUnit tests into string_kunit.c
>    string: Convert KUnit test names to standard convention
> 
>   MAINTAINERS         |   2 -
>   lib/Kconfig.debug   |  10 --
>   lib/Makefile        |   2 -
>   lib/strcat_kunit.c  | 104 ------------------
>   lib/string_kunit.c  | 258 +++++++++++++++++++++++++++++++++++++++-----
>   lib/strscpy_kunit.c | 142 ------------------------
>   6 files changed, 230 insertions(+), 288 deletions(-)
>   delete mode 100644 lib/strcat_kunit.c
>   delete mode 100644 lib/strscpy_kunit.c
> 

I tested all of the patches in the series with kunit_tool, and 
everything works correctly.

Thank you for doing this!

Tested-by: Ivan Orlov <ivan.orlov0322@...il.com>
-- 
Kind regards,
Ivan Orlov