linux-kernel - Re: [PATCH v4 1/2] kunit: unregister the device on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf0dc8a8-d5e9-4402-8305-5b7a954e6382@web.de>
Date: Fri, 19 Apr 2024 18:32:05 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Wander Lairson Costa <wander@...hat.com>, kunit-dev@...glegroups.com,
 linux-kselftest@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Brendan Higgins <brendan.higgins@...ux.dev>, David Gow
 <davidgow@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Matti Vaittinen <mazziesaccount@...il.com>,
 Maxime Ripard <mripard@...nel.org>, Rae Moar <rmoar@...gle.com>,
 Shuah Khan <skhan@...uxfoundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] kunit: unregister the device on error

> > kunit_init_device() should unregister the device on bus register error,
> > but mistakenly it tries to unregister the bus.
> >
> > Unregister the device instead of the bus.
…
> Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Would you ever like to distinguish hardware register errors from
item registration failures according to further improved commit messages?

Regards,
Markus