linux-kernel - Re: [PATCH] drivers: use __free attribute instead of of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE8VWiLErhCkD9w+Rbh8mTnRQs-4iJDBrWdVXXFFFDQ3yeTaLg@mail.gmail.com>
Date: Fri, 19 Apr 2024 23:16:37 +0530
From: Shresth Prasad <shresthprasad7@...il.com>
To: vincenzo.mezzela@...il.com
Cc: gregkh@...uxfoundation.org, 
	Javier Carrasco <javier.carrasco.cruz@...il.com>, Julia Lawall <julia.lawall@...ia.fr>, 
	linux-kernel@...r.kernel.org, rafael@...nel.org, 
	Shuah Khan <skhan@...uxfoundation.org>, sudeep.holla@....com
Subject: Re: [PATCH] drivers: use __free attribute instead of of_node_put()

> Please fix the subject line to be "backlight: <driver>: ...". I came
> very close to deleting this patch without reading it ;-) .

Really sorry about that, I'll fix it.

> Do we need to get dev->of_node at all? The device, which we are
> borrowing, already owns a reference to the node so I don't see
> any point in this function taking an extra one.
>
> So why not simply make this:
>
>     struct device_node *np = dev->of_node;

Looking at it again, I'm not sure why the call to of_node_put is there in
the first place. I think removing it would be fine.

I'll fix both of these issues and send a patch v2.

Regards,
Shresth