linux-kernel - Re: [PATCH][next] drivers: video: Simplify device_node cleanup using _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe7df45c-b61f-4e8a-a13f-1e6a85cf83bf@gmail.com>
Date: Sat, 20 Apr 2024 12:41:07 +0530 (GMT+05:30)
From: Shresth Prasad <shresthprasad7@...il.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: daniel.thompson@...aro.org, deller@....de,
	dri-devel@...ts.freedesktop.org, javier.carrasco.cruz@...il.com,
	jingoohan1@...il.com, julia.lawall@...ia.fr, lee@...nel.org,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH][next] drivers: video: Simplify device_node cleanup
 using __free

20 Apr 2024 1:13:42 am Dmitry Baryshkov <dmitry.baryshkov@...aro.org>:

> On Sat, Apr 20, 2024 at 12:22:41AM +0530, Shresth Prasad wrote:
>> 
>>> Please fix the subject line to be "backlight: <driver>: ...". I came
>>> very close to deleting this patch without reading it ;-) .
>> 
>> Really sorry about that, I'll fix it.
>> 
>>> Do we need to get dev->of_node at all? The device, which we are
>>> borrowing, already owns a reference to the node so I don't see
>>> any point in this function taking an extra one.
>>> 
>>> So why not simply make this:
>>> 
>>>     struct device_node *np = dev->of_node;
>> 
>> Looking at it again, I'm not sure why the call to `of_node_put` is there in the first place. I think removing it will be fine.
>> 
>> I'll fix both of these issues and send a patch v2.
> 
> Just a stupid quesiton: on which platform was this patch tested?
> 
> -- 
> With best wishes
> Dmitry
I tested the patch on a x86_64 qemu virtual machine

Regards,
Shresth