linux-kernel - Re: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240420112347.6bd1daa4@jic23-huawei>
Date: Sat, 20 Apr 2024 11:23:47 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: "Paller, Kim Seer" <KimSeer.Paller@...log.com>
Cc: David Lechner <dlechner@...libre.com>, "linux-iio@...r.kernel.org"
 <linux-iio@...r.kernel.org>, "devicetree@...r.kernel.org"
 <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, Lars-Peter Clausen <lars@...afoo.de>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 "Hennerich, Michael" <Michael.Hennerich@...log.com>
Subject: Re: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC

On Tue, 16 Apr 2024 14:18:23 +0000
"Paller, Kim Seer" <KimSeer.Paller@...log.com> wrote:

> > -----Original Message-----
> > From: Jonathan Cameron <jic23@...nel.org>
> > Sent: Saturday, April 13, 2024 11:27 PM
> > To: Paller, Kim Seer <KimSeer.Paller@...log.com>
> > Cc: linux-iio@...r.kernel.org; devicetree@...r.kernel.org; linux-
> > kernel@...r.kernel.org; Lars-Peter Clausen <lars@...afoo.de>; Rob Herring
> > <robh@...nel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>;
> > Conor Dooley <conor+dt@...nel.org>; Liam Girdwood
> > <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>; David Lechner
> > <dlechner@...libre.com>; Hennerich, Michael
> > <Michael.Hennerich@...log.com>
> > Subject: Re: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC
> > 
> > [External]
> > 
> > On Fri, 12 Apr 2024 11:21:01 +0800
> > Kim Seer Paller <kimseer.paller@...log.com> wrote:
> >   
> > > Define the sysfs interface for toggle capable channels.
> > >
> > > Toggle enabled channels will have:
> > >
> > >  * out_currentY_toggle_en
> > >  * out_currentY_raw0
> > >  * out_currentY_raw1
> > >  * out_currentY_symbol
> > >
> > > The common interface present in all channels is:
> > >
> > >  * out_currentY_raw (not present in toggle enabled channels)
> > >  * out_currentY_raw_available
> > >  * out_currentY_powerdown
> > >  * out_currentY_scale
> > >  * out_currentY_offset
> > >
> > > Co-developed-by: Michael Hennerich <michael.hennerich@...log.com>
> > > Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
> > > Signed-off-by: Kim Seer Paller <kimseer.paller@...log.com>
> > > ---
> > >  .../ABI/testing/sysfs-bus-iio-dac-ltc2672     | 30 +++++++++++++++++++  
> > 
> > You can only have per device ABI defined if that is the only user
> > of the ABI.  That may actually be true here but given I've asked you to
> > generalize
> > the voltage equivalent, I think we've shown this is general enough that the
> > current
> > version should also be raised to sysfs-bus-iio-dac  
> 
> I'm still getting familiar with ABI documentation. If I understand correctly,
> generalizing the documentation to cover both parts would also mean we remove
> the overlapping sections from the ltc2688 ABI. Is that the correct approach?
> 
> 

Yes.  To test this build the html docs. IIRC that will complain about duplicate
ABI definitions.  I'm sure there is a way to test just ABI docs build but
I've never really looked into it.

Jonathan