linux-kernel - Re: [PATCH 1/4] usb: typec: ucsi: Fix null deref in trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024042056-shortlist-grope-0216@gregkh>
Date: Sat, 20 Apr 2024 15:20:01 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
	linux-usb@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Jameson Thies <jthies@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Benson Leung <bleung@...gle.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Rajaram Regupathy <rajaram.regupathy@...el.com>,
	Saranya Gopal <saranya.gopal@...el.com>
Subject: Re: [PATCH 1/4] usb: typec: ucsi: Fix null deref in trace

On Sat, Apr 20, 2024 at 03:15:16PM +0200, Markus Elfring wrote:
> > ucsi_register_altmode checks IS_ERR on returned pointer and treats
> > NULL as valid. This results in a null deref when
> > trace_ucsi_register_altmode is called.
> 
> I find that the change description can be improved further.
> Is another imperative wording desirable?
> 
> Can it be nicer to use the term “dereference” for the final commit message?

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot