linux-kernel - Re: [PATCH v9 5/9] clk: mmp: Add Marvell PXA1908 clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb221864-0044-4ea5-bbee-7545d10cb130@skole.hr>
Date: Sat, 20 Apr 2024 15:32:56 +0200
From: Duje Mihanović <duje.mihanovic@...le.hr>
To: Stephen Boyd <sboyd@...nel.org>, Catalin Marinas
 <catalin.marinas@....com>, Conor Dooley <conor+dt@...nel.org>,
 "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
 Haojian Zhuang <haojian.zhuang@...aro.org>, Kees Cook
 <keescook@...omium.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Linus Walleij <linus.walleij@...aro.org>, Lubomir Rintel <lkundrak@...sk>,
 Michael Turquette <mturquette@...libre.com>, Rob Herring
 <robh+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Tony Lindgren <tony@...mide.com>, Tony Luck <tony.luck@...el.com>,
 Will Deacon <will@...nel.org>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 Karel Balej <balejk@...fyz.cz>, David Wronek <david@...nlining.org>,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v9 5/9] clk: mmp: Add Marvell PXA1908 clock driver

On 4/20/24 00:24, Stephen Boyd wrote:
> Quoting Duje Mihanović (2024-04-19 07:31:14)
>> On Friday, April 12, 2024 4:57:09 AM GMT+2 Stephen Boyd wrote:
>>> Quoting Duje Mihanović (2024-04-11 03:15:34)
>>>
>>>> On 4/11/2024 10:00 AM, Stephen Boyd wrote:
>>>>> Is there a reason this file can't be a platform driver?
>>>>
>>>> Not that I know of, I did it like this only because the other in-tree
>>>> MMP clk drivers do so. I guess the initialization should look like any
>>>> of the qcom GCC drivers then?
>>>
>>> Yes.
>>
>> With the entire clock driver code in one file this is quite messy as I also
>> needed to add module_init and module_exit functions to (un)register each
>> platform driver, presumably because the module_platform_driver macro doesn't
>> work with multiple platform drivers in one module. If I split up the driver
>> code for each clock controller block into its own file (such as clk-of-
>> pxa1908-apbc.c) as I believe is the best option, should the commits be split
>> up accordingly as well?
> 
> Sure. Why is 'of' in the name? Maybe that is unnecessary?

That seems to be a historical leftover from when Marvell was just adding 
DT support to the ARM32 MMP SoCs which Rob followed along with in the 
PXA1928 clk driver and so have I. Should I drop it then as Marvell has 
in the PXA1908 vendor kernel?

Regards,
--
Duje