linux-kernel - Re: [PATCH -next v2] riscv: kdump: fix crashkernel reserving problem on RISC-V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 22 Apr 2024 00:13:57 +0800
From: Mingzheng Xing <xingmingzheng@...as.ac.cn>
To: bhe@...hat.com
Cc: ajones@...tanamicro.com,
	akpm@...ux-foundation.org,
	alexghiti@...osinc.com,
	aou@...s.berkeley.edu,
	bjorn@...osinc.com,
	chenjiahao16@...wei.com,
	conor.dooley@...rochip.com,
	jszhang@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	palmer@...belt.com,
	palmer@...osinc.com,
	patchwork-bot+linux-riscv@...nel.org,
	paul.walmsley@...ive.com,
	robh@...nel.org,
	thunder.leizhen@...wei.com,
	zephray@...look.com,
	stable@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mingzheng Xing <xingmingzheng@...as.ac.cn>
Subject: Re: [PATCH -next v2] riscv: kdump: fix crashkernel reserving problem on RISC-V

>Hi,
>
>On 10/12/23 at 08:40pm, patchwork-bot+linux-riscv@...nel.org wrote:
>> Hello:
>> 
>> This patch was applied to riscv/linux.git (fixes)
>> by Palmer Dabbelt <palmer@...osinc.com>:
>
>This patches fixes a regression of one risc-v patch which Andrew picked
>into his akpm tree. Later, Andrew merged those two into one patch, now
>it shows up in next/master as:
>
>39365395046f riscv: kdump: use generic interface to simplify crashkernel reservation
>
>Maybe it can be droppped in risv-v git tree so as not to cause conflict
>when merging.
>

Hi,

If I understand right, after commit[1] is merged into Linus's tree,
commit[2] doesn't need to be merged in, because [1] contains [2]. This may
not have an effect on the master branch. But commit[2] goes into the 6.6.y
branch alone and commit[1] doesn't, which creates a trouble in the 6.6
stable branch.

commit 39365395046f ("riscv: kdump: use generic interface to simplify crashkernel reservation") [1]
commit 1d6cd2146c2b ("riscv: kdump: fix crashkernel reserving problem on RISC-V") [2]

Thanks,
Mingzheng

>Thanks
>Baoquan
>
>> 
>> On Mon, 25 Sep 2023 10:43:33 +0800 you wrote:
>> > When testing on risc-v QEMU environment with "crashkernel="
>> > parameter enabled, a problem occurred with the following
>> > message:
>> > 
>> > [    0.000000] crashkernel low memory reserved: 0xf8000000 - 0x100000000 (128 MB)
>> > [    0.000000] crashkernel reserved: 0x0000000177e00000 - 0x0000000277e00000 (4096 MB)
>> > [    0.000000] ------------[ cut here ]------------
>> > [    0.000000] WARNING: CPU: 0 PID: 0 at kernel/resource.c:779 __insert_resource+0x8e/0xd0
>> > [    0.000000] Modules linked in:
>> > [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 6.6.0-rc2-next-20230920 #1
>> > [    0.000000] Hardware name: riscv-virtio,qemu (DT)
>> > [    0.000000] epc : __insert_resource+0x8e/0xd0
>> > [    0.000000]  ra : insert_resource+0x28/0x4e
>> > [    0.000000] epc : ffffffff80017344 ra : ffffffff8001742e sp : ffffffff81203db0
>> > [    0.000000]  gp : ffffffff812ece98 tp : ffffffff8120dac0 t0 : ff600001f7ff2b00
>> > [    0.000000]  t1 : 0000000000000000 t2 : 3428203030303030 s0 : ffffffff81203dc0
>> > [    0.000000]  s1 : ffffffff81211e18 a0 : ffffffff81211e18 a1 : ffffffff81289380
>> > [    0.000000]  a2 : 0000000277dfffff a3 : 0000000177e00000 a4 : 0000000177e00000
>> > [    0.000000]  a5 : ffffffff81289380 a6 : 0000000277dfffff a7 : 0000000000000078
>> > [    0.000000]  s2 : ffffffff81289380 s3 : ffffffff80a0bac8 s4 : ff600001f7ff2880
>> > [    0.000000]  s5 : 0000000000000280 s6 : 8000000a00006800 s7 : 000000000000007f
>> > [    0.000000]  s8 : 0000000080017038 s9 : 0000000080038ea0 s10: 0000000000000000
>> > [    0.000000]  s11: 0000000000000000 t3 : ffffffff80a0bc00 t4 : ffffffff80a0bc00
>> > [    0.000000]  t5 : ffffffff80a0bbd0 t6 : ffffffff80a0bc00
>> > [    0.000000] status: 0000000200000100 badaddr: 0000000000000000 cause: 0000000000000003
>> > [    0.000000] [<ffffffff80017344>] __insert_resource+0x8e/0xd0
>> > [    0.000000] ---[ end trace 0000000000000000 ]---
>> > [    0.000000] Failed to add a Crash kernel resource at 177e00000
>> > 
>> > [...]
>> 
>> Here is the summary with links:
>>   - [-next,v2] riscv: kdump: fix crashkernel reserving problem on RISC-V
>>     https://git.kernel.org/riscv/c/1d6cd2146c2b
>
>
>> 
>> You are awesome, thank you!
>> -- 
>> Deet-doot-dot, I am a bot.
>> https://korg.docs.kernel.org/patchwork/pwbot.html
>>