linux-kernel - Re: [PATCH v8 2/4] drm/bridge: add lvds controller support for sam9x7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 21 Apr 2024 20:24:25 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Dharma Balasubiramani <dharma.b@...rochip.com>
Cc: "andrzej . hajda @ intel . com" <andrzej.hajda@...el.com>, 
	"neil . armstrong @ linaro . org" <neil.armstrong@...aro.org>, "rfoss @ kernel . org" <rfoss@...nel.org>, 
	"Laurent . pinchart @ ideasonboard . com" <Laurent.pinchart@...asonboard.com>, "jonas @ kwiboo . se" <jonas@...boo.se>, 
	"jernej . skrabec @ gmail . com" <jernej.skrabec@...il.com>, 
	"maarten . lankhorst @ linux . intel . com" <maarten.lankhorst@...ux.intel.com>, "mripard @ kernel . org" <mripard@...nel.org>, 
	"tzimmermann @ suse . de" <tzimmermann@...e.de>, "airlied @ gmail . com" <airlied@...il.com>, 
	"daniel @ ffwll . ch" <daniel@...ll.ch>, "robh+dt @ kernel . org" <robh+dt@...nel.org>, 
	"krzysztof . kozlowski+dt @ linaro . org" <krzysztof.kozlowski+dt@...aro.org>, "conor+dt @ kernel . org" <conor+dt@...nel.org>, 
	"linux @ armlinux . org . uk" <linux@...linux.org.uk>, 
	"Nicolas . Ferre @ microchip . com" <Nicolas.Ferre@...rochip.com>, 
	"alexandre . belloni @ bootlin . com" <alexandre.belloni@...tlin.com>, "claudiu . beznea @ tuxon . dev" <claudiu.beznea@...on.dev>, 
	"Manikandan . M @ microchip . com" <Manikandan.M@...rochip.com>, "arnd @ arndb . de" <arnd@...db.de>, 
	"geert+renesas @ glider . be" <geert+renesas@...der.be>, "Jason @ zx2c4 . com" <Jason@...c4.com>, 
	"mpe @ ellerman . id . au" <mpe@...erman.id.au>, "gerg @ linux-m68k . org" <gerg@...ux-m68k.org>, 
	"rdunlap @ infradead . org" <rdunlap@...radead.org>, "vbabka @ suse . cz" <vbabka@...e.cz>, 
	"dri-devel @ lists . freedesktop . org" <dri-devel@...ts.freedesktop.org>, "devicetree @ vger . kernel . org" <devicetree@...r.kernel.org>, 
	"linux-kernel @ vger . kernel . org" <linux-kernel@...r.kernel.org>, 
	"oe-kbuild-all @ lists . linux . dev" <oe-kbuild-all@...ts.linux.dev>, 
	"Hari . PrasathGE @ microchip . com" <Hari.PrasathGE@...rochip.com>
Subject: Re: [PATCH v8 2/4] drm/bridge: add lvds controller support for sam9x7

On Sun, Apr 21, 2024 at 06:40:48AM +0530, Dharma Balasubiramani wrote:
> Add a new LVDS controller driver for sam9x7 which does the following:
> - Prepares and enables the LVDS Peripheral clock
> - Defines its connector type as DRM_MODE_CONNECTOR_LVDS and adds itself
> to the global bridge list.
> - Identifies its output endpoint as panel and adds it to the encoder
> display pipeline
> - Enables the LVDS serializer
> 
> Signed-off-by: Manikandan Muralidharan <manikandan.m@...rochip.com>
> Signed-off-by: Dharma Balasubiramani <dharma.b@...rochip.com>
> Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@...rochip.com>
> ---
> Changelog
> v7 -> v8
> - Assign ret variable properly before checking it for err.
> v6 -> v7
> - Remove setting encoder type from bridge driver.
> - Drop clk_disable() from pm_runtime_get_sync() error handling.
> - Use devm_clk_get() instead of prepared version.
> - Hence use clk_prepare_enable() and clk_disable_unprepare().
> - Use devm_drm_of_get_bridge() instead of devm_drm_panel_bridge_add().
> - Add error check for devm_pm_runtime_enable().
> - Use dev_err() instead of DRM_DEV_ERROR() as it is deprecated.
> - Add missing Acked-by tag.
> v5 -> v6
> - No Changes.
> v4 -> v5
> - Drop the unused variable 'format'.
> - Use DRM wrapper for dev_err() to maintain uniformity.
> - return -ENODEV instead of -EINVAL to maintain consistency with other DRM
>   bridge drivers.
> v3 -> v4
> - No changes.
> v2 ->v3
> - Correct Typo error "serializer".
> - Consolidate get() and prepare() functions and use devm_clk_get_prepared().
> - Remove unused variable 'ret' in probe().
> - Use devm_pm_runtime_enable() and drop the mchp_lvds_remove().
> v1 -> v2
> - Drop 'res' variable and combine two lines into one.
> - Handle deferred probe properly, use dev_err_probe().
> - Don't print anything on deferred probe. Dropped print.
> - Remove the MODULE_ALIAS and add MODULE_DEVICE_TABLE().
> - symbol 'mchp_lvds_driver' was not declared. It should be static.
> ---
>  drivers/gpu/drm/bridge/Kconfig          |   7 +
>  drivers/gpu/drm/bridge/Makefile         |   1 +
>  drivers/gpu/drm/bridge/microchip-lvds.c | 229 ++++++++++++++++++++++++
>  3 files changed, 237 insertions(+)
>  create mode 100644 drivers/gpu/drm/bridge/microchip-lvds.c
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>


-- 
With best wishes
Dmitry