linux-kernel - RE: [PATCH v5 1/4] rust: uaccess: add userspace pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 21 Apr 2024 19:48:31 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Alice Ryhl' <aliceryhl@...gle.com>
CC: "boqun.feng@...il.com" <boqun.feng@...il.com>, "a.hindborg@...sung.com"
	<a.hindborg@...sung.com>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
	"arnd@...db.de" <arnd@...db.de>, "arve@...roid.com" <arve@...roid.com>,
	"benno.lossin@...ton.me" <benno.lossin@...ton.me>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "brauner@...nel.org" <brauner@...nel.org>,
	"cmllamas@...gle.com" <cmllamas@...gle.com>, "gary@...yguo.net"
	<gary@...yguo.net>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "joel@...lfernandes.org"
	<joel@...lfernandes.org>, "keescook@...omium.org" <keescook@...omium.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, "maco@...roid.com"
	<maco@...roid.com>, "ojeda@...nel.org" <ojeda@...nel.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"surenb@...gle.com" <surenb@...gle.com>, "tkjos@...roid.com"
	<tkjos@...roid.com>, "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"wedsonaf@...il.com" <wedsonaf@...il.com>, "willy@...radead.org"
	<willy@...radead.org>
Subject: RE: [PATCH v5 1/4] rust: uaccess: add userspace pointers

From: Alice Ryhl
> Sent: 21 April 2024 19:38
> 
> On Sun, Apr 21, 2024 at 8:08 PM David Laight <David.Laight@...lab.com> wrote:
> >
> > Should you be implementing 'struct iov_iter' ?
> >
> > Even if it means creating an IO_UBUF for ioctls?
> > (Although that might take some 'fettling' for read+write for ioctls.)
> 
> That seems to be intended for when you have several chunks of memory
> in userspace that you want to treat as one contiguous chunk. That's
> not something I need in the Android Binder driver.

It also transparently supports in-kernel users and some other cases.

I think there is a patch intended for 6.10 that removes the 'read'
and 'write' driver 'ops' and requires that drivers support 'read_iter'
and 'write_iter'.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)