linux-kernel - Re: [PATCH v2] memcg: simple cleanup of stats update functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 20 Apr 2024 19:12:05 -0700
From: "T.J. Mercier" <tjmercier@...gle.com>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Johannes Weiner <hannes@...xchg.org>, 
	Michal Hocko <mhocko@...nel.org>, Roman Gushchin <roman.gushchin@...ux.dev>, 
	Muchun Song <muchun.song@...ux.dev>, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] memcg: simple cleanup of stats update functions

On Sat, Apr 20, 2024 at 4:25 PM Shakeel Butt <shakeel.butt@...ux.dev> wrote:
>
> mod_memcg_lruvec_state() is never called from outside of memcontrol.c
> and with always irq disabled. So, replace it with the irq disabled
> version and add an assert that irq is disabled in the caller.
>
> Similarly mod_objcg_state() is not called from outside of memcontrol.c,
> so simply make it static and change it's name to __mod_objcg_state().
>
> Signed-off-by: Shakeel Butt <shakeel.butt@...ux.dev>
> Acked-by: Johannes Weiner <hannes@...xchg.org>

Reviewed-by: T.J. Mercier <tjmercier@...gle.com>