linux-kernel - Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support for vivobook fan profiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202404211141.mYHti4dq-lkp@intel.com>
Date: Sun, 21 Apr 2024 11:32:58 +0800
From: kernel test robot <lkp@...el.com>
To: Mohamed Ghanmi <mohamed.ghanmi@...com.tn>, hdegoede@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, corentin.chary@...il.com,
	ilpo.jarvinen@...ux.intel.com, platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org, "Luke D . Jones" <luke@...nes.dev>,
	Mohamed Ghanmi <mohamed.ghanmi@...com.tn>
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support for vivobook
 fan profiles

Hi Mohamed,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20240418]
[cannot apply to linus/master v6.9-rc4 v6.9-rc3 v6.9-rc2 v6.9-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mohamed-Ghanmi/platform-x86-asus-wmi-add-support-for-vivobook-fan-profiles/20240419-055003
base:   next-20240418
patch link:    https://lore.kernel.org/r/20240418214727.10658-2-mohamed.ghanmi%40supcom.tn
patch subject: [PATCH v2 1/1] platform/x86: asus-wmi: add support for vivobook fan profiles
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240421/202404211141.mYHti4dq-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240421/202404211141.mYHti4dq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404211141.mYHti4dq-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/platform/x86/asus-wmi.c: In function 'throttle_thermal_policy_store':
>> drivers/platform/x86/asus-wmi.c:3730:56: error: 'asus' undeclared (first use in this function)
    3730 |         u8 max_mode = throttle_thermal_policy_max_mode(asus);
         |                                                        ^~~~
   drivers/platform/x86/asus-wmi.c:3730:56: note: each undeclared identifier is reported only once for each function it appears in


vim +/asus +3730 drivers/platform/x86/asus-wmi.c

  3725	
  3726	static ssize_t throttle_thermal_policy_store(struct device *dev,
  3727					    struct device_attribute *attr,
  3728					    const char *buf, size_t count)
  3729	{
> 3730		u8 max_mode = throttle_thermal_policy_max_mode(asus);
  3731		struct asus_wmi *asus = dev_get_drvdata(dev);
  3732		u8 new_mode;
  3733		int result;
  3734		int err;
  3735	
  3736		result = kstrtou8(buf, 10, &new_mode);
  3737		if (result < 0)
  3738			return result;
  3739	
  3740		if (new_mode > max_mode)
  3741			return -EINVAL;
  3742	
  3743		asus->throttle_thermal_policy_mode = new_mode;
  3744		err = throttle_thermal_policy_write(asus);
  3745		if (err)
  3746			return err;
  3747	
  3748		/*
  3749		 * Ensure that platform_profile updates userspace with the change to ensure
  3750		 * that platform_profile and throttle_thermal_policy_mode are in sync.
  3751		 */
  3752		platform_profile_notify();
  3753	
  3754		return count;
  3755	}
  3756	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki