[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b6f3d628-077e-486a-97f2-267324a76e9c@gmail.com>
Date: Sun, 21 Apr 2024 06:13:58 +0530
From: sundar <prosunofficial@...il.com>
To: Joe Perches <joe@...ches.com>, heikki.krogerus@...ux.intel.com,
gregkh@...uxfoundation.org, neil.armstrong@...aro.org,
dmitry.baryshkov@...aro.org, u.kleine-koenig@...gutronix.de,
christophe.jaillet@...adoo.fr
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
skhan@...uxfoundation.org, javier.carrasco.cruz@...il.com
Subject: Re: [PATCH v2] remove indentation for common path [linux-next]
On 20/04/24 22:37, Joe Perches wrote:
> On Sat, 2024-04-20 at 22:19 +0530, sundar wrote:
>
>
>> ```
> @@ -321,35 +321,37 @@ static int nb7vpq904m_parse_data_lanes_mapping(struct nb7vpq904m *nb7)
>
> ep = of_graph_get_endpoint_by_regs(nb7->client->dev.of_node, 1, 0);
>
> - if (ep) {
> - ret = of_property_count_u32_elems(ep, "data-lanes");
> - if (ret == -EINVAL)
> - /* Property isn't here, consider default mapping */
> - goto out_done;
> - if (ret < 0)
> - goto out_error;
> -
> - if (ret != DATA_LANES_COUNT) {
> - dev_err(&nb7->client->dev, "expected 4 data lanes\n");
> - ret = -EINVAL;
> - goto out_error;
> - }
> + if (!ep)
> + return 0;
> ```
>
>
> Not equivalent code as the out_error:
>
> of_node_put(ep);
>
> isn't done
>
>
Hi joe perches,
If ep is null, I believe we dont need to call of_node_put. Because
passing null pointer to of_node_put() make no difference.
In of_node_put() definition, if pointer is null, there is no operation.
Thanks,
Sundar
Powered by blists - more mailing lists