[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0fa7ef43-29c2-439b-b82f-5c287001f850@gmail.com>
Date: Sun, 21 Apr 2024 18:11:27 +0530
From: Mohammad Shehar Yaar Tausif <sheharyaar48@...il.com>
To: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Thierry Reding
<thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>
Cc: Thierry Reding <treding@...dia.com>, linux-sound@...r.kernel.org,
devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: tegra30-i2s: convert to dt schema
On 4/20/24 11:20 PM, Mohammad Shehar Yaar Tausif wrote:
> Convert NVIDIA Tegra30 I2S binding to DT schema.
>
> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@...il.com>
> ---
> .../bindings/sound/nvidia,tegra30-i2s.txt | 27 --------
> .../bindings/sound/nvidia,tegra30-i2s.yaml | 68 +++++++++++++++++++
> 2 files changed, 68 insertions(+), 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt
> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt
> deleted file mode 100644
> index 38caa936f6f8..000000000000
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -NVIDIA Tegra30 I2S controller
> -
> -Required properties:
> -- compatible : For Tegra30, must contain "nvidia,tegra30-i2s". For Tegra124,
> - must contain "nvidia,tegra124-i2s". Otherwise, must contain
> - "nvidia,<chip>-i2s" plus at least one of the above, where <chip> is
> - tegra114 or tegra132.
> -- reg : Should contain I2S registers location and length
> -- clocks : Must contain one entry, for the module clock.
> - See ../clocks/clock-bindings.txt for details.
> -- resets : Must contain an entry for each entry in reset-names.
> - See ../reset/reset.txt for details.
> -- reset-names : Must include the following entries:
> - - i2s
> -- nvidia,ahub-cif-ids : The list of AHUB CIF IDs for this port, rx (playback)
> - first, tx (capture) second. See nvidia,tegra30-ahub.txt for values.
> -
> -Example:
> -
> -i2s@...80300 {
> - compatible = "nvidia,tegra30-i2s";
> - reg = <0x70080300 0x100>;
> - nvidia,ahub-cif-ids = <4 4>;
> - clocks = <&tegra_car 11>;
> - resets = <&tegra_car 11>;
> - reset-names = "i2s";
> -};
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml
> new file mode 100644
> index 000000000000..3809e4049fe1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nvidia,tegra30-i2s.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra30 I2S controller
> +
> +maintainers:
> + - Thierry Reding <treding@...dia.com>
> + - Jon Hunter <jonathanh@...dia.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - nvidia,tegra124-i2s
> + - nvidia,tegra30-i2s
> + - items:
> + - enum:
> + - nvidia,tegra114-i2s
> + - nvidia,tegra132-i2s
> + - const: nvidia,tegra124-i2s
> + - const: nvidia,tegra30-i2s
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: i2s
> +
> + nvidia,ahub-cif-ids:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description: |
> + The list of AHUB CIF IDs for this port, rx (playback)
> + first, tx (capture) second. See nvidia,tegra30-ahub.txt for values.
> + minItems: 2
> + maxItems: 2
> + items:
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - resets
> + - reset-names
> + - nvidia,ahub-cif-ids
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2s@...80300 {
> + compatible = "nvidia,tegra30-i2s";
> + reg = <0x70080300 0x100>;
> + nvidia,ahub-cif-ids = <4 4>;
> + clocks = <&tegra_car 11>;
> + resets = <&tegra_car 11>;
> + reset-names = "i2s";
> + };
> +...
There was a mistake in setting items type under 'nvidia, ahub-cif-ids'.
It has been fixed in v2 patch. Sorry for the mistake.
v2 :
https://lore.kernel.org/all/20240421123037.75680-1-sheharyaar48@gmail.com
Powered by blists - more mailing lists