linux-kernel - Re: [PATCH wireless v2] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a2bf374-0def-4c41-8260-20fd7428bad6@quicinc.com>
Date: Mon, 22 Apr 2024 09:23:58 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Su Hui <suhui@...china.com>, <kvalo@...nel.org>, <jjohnson@...nel.org>,
        <nathan@...nel.org>, <ndesaulniers@...gle.com>, <morbo@...gle.com>,
        <justinstitt@...gle.com>
CC: <c_mkenna@....qualcomm.com>, <linux-wireless@...r.kernel.org>,
        <ath10k@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <llvm@...ts.linux.dev>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH wireless v2] wifi: ath10k: Fix an error code problem in
 ath10k_dbg_sta_write_peer_debug_trigger()

On 4/21/2024 8:42 PM, Su Hui wrote:
> Clang Static Checker (scan-build) Warning:
> drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3
> Value stored to 'ret' is never read.
> 
> Return 'ret' rather than 'count' when 'ret' stores an error code.
> By the way, remove some useless code.
> 
> Fixes: ee8b08a1be82 ("ath10k: add debugfs support to get per peer tids log via tracing")
> Signed-off-by: Su Hui <suhui@...china.com>

(try that again)
Acked-by: Jeff Johnson <quic_jjohnson@...cinc.com>