linux-kernel - Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0exs067.fsf@intel.com>
Date: Mon, 22 Apr 2024 21:49:04 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Melissa Wen
 <mwen@...lia.com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David
 Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers

On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Assuming it builds, and nothing depends on other stuff from kernel.h via
drm_fixed.h,

Reviewed-by: Jani Nikula <jani.nikula@...el.com>

> ---
>  include/drm/drm_fixed.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h
> index 81572d32db0c..387fb81d5b81 100644
> --- a/include/drm/drm_fixed.h
> +++ b/include/drm/drm_fixed.h
> @@ -25,8 +25,9 @@
>  #ifndef DRM_FIXED_H
>  #define DRM_FIXED_H
>  
> -#include <linux/kernel.h>
>  #include <linux/math64.h>
> +#include <linux/types.h>
> +#include <linux/wordpart.h>
>  
>  typedef union dfixed {
>  	u32 full;

-- 
Jani Nikula, Intel