[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240422185803.3575319-3-sean.anderson@linux.dev>
Date: Mon, 22 Apr 2024 14:58:02 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
linux-phy@...ts.infradead.org
Cc: Vinod Koul <vkoul@...nel.org>,
linux-kernel@...r.kernel.org,
Michal Simek <michal.simek@....com>,
linux-arm-kernel@...ts.infradead.org,
Kishon Vijay Abraham I <kishon@...nel.org>,
Sean Anderson <sean.anderson@...ux.dev>
Subject: [PATCH 2/3] phy: zynqmp: Don't wait for PLL lock on nonzero PCIe lanes
Similarly to DisplayPort, nonzero PCIe lanes never achieve PLL lock [1].
Don't wait for them.
Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
---
Maybe it's actually that only the final lane configured locks? I haven't
tested this out.
drivers/phy/xilinx/phy-zynqmp.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
index b507ed4c3053..08c88dcd7799 100644
--- a/drivers/phy/xilinx/phy-zynqmp.c
+++ b/drivers/phy/xilinx/phy-zynqmp.c
@@ -624,11 +624,13 @@ static int xpsgtr_phy_power_on(struct phy *phy)
if (!xpsgtr_phy_init_required(gtr_phy))
return ret;
/*
- * Wait for the PLL to lock. For DP, only wait on DP0 to avoid
- * cumulating waits for both lanes. The user is expected to initialize
- * lane 0 last.
+ * Wait for the PLL to lock. For DP and PCIe, only wait on instance 0
+ * to avoid cumulative waits for both lanes. The user is expected to
+ * initialize lane 0 last.
*/
- if (gtr_phy->protocol != ICM_PROTOCOL_DP || !gtr_phy->instance)
+ if ((gtr_phy->protocol != ICM_PROTOCOL_DP &&
+ gtr_phy->protocol != ICM_PROTOCOL_PCIE) ||
+ !gtr_phy->instance)
ret = xpsgtr_wait_pll_lock(phy);
return ret;
--
2.35.1.1320.gc452695387.dirty
Powered by blists - more mailing lists