linux-kernel - Re: [RFC PATCH v7 5/6] perf stat: Add retire latency print functions to print out at the very end of print out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Apr 2024 13:02:04 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: weilin.wang@...el.com
Cc: Ian Rogers <irogers@...gle.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Perry Taylor <perry.taylor@...el.com>, Samantha Alt <samantha.alt@...el.com>, 
	Caleb Biggers <caleb.biggers@...el.com>
Subject: Re: [RFC PATCH v7 5/6] perf stat: Add retire latency print functions
 to print out at the very end of print out

On Mon, Apr 22, 2024 at 12:55 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> On Tue, Apr 2, 2024 at 2:46 PM <weilin.wang@...el.com> wrote:
> >
> > From: Weilin Wang <weilin.wang@...el.com>
> >
> > Add print out functions so that users could read retire latency values.
> >
> > Example output:
> >
> >  Performance counter stats for 'system wide':
> >
> >             25,717      MEM_INST_RETIRED.SPLIT_STORES    #      2.2 %  tma_split_stores
> >         28,365,080      CPU_CLK_UNHALTED.THREAD
> >              24.00      MEM_INST_RETIRED.SPLIT_STORES:p  #       96        4
> >
> >        2.054365083 seconds time elapsed
> >
> > This output of retire latency data is in format:
> >  <val> <event-name> # <sum> <count>.
>
> Nop, please follow the perf stat output format.  It'd be
>
>   <sum> <event-name> # ...
>
> Hmm.. maybe you don't need this at all as it'll have the event
> anyway (probably without the 'p' modifier like in the example
> above).
>
> Then I think you can just add a metric value saying the average
> latency in the comment area.
>
>   Performance counter stats for 'system wide':
>
>              25,717      MEM_INST_RETIRED.SPLIT_STORES    #      2.2 %
>  tma_split_stores
>                                                                      #
>      24.0  average latency

Sorry for the line wrapping.  They should be in the same line.

Thanks,
Namhyung