linux-kernel - Re: [PATCH 1/7] block: Init for CBD(CXL Block Device)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd1df8f1-f80c-5a3a-f804-3e360bfac339@easystack.cn>
Date: Tue, 23 Apr 2024 06:41:11 +0800
From: Dongsheng Yang <dongsheng.yang@...ystack.cn>
To: Randy Dunlap <rdunlap@...radead.org>, dan.j.williams@...el.com,
 axboe@...nel.dk
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-cxl@...r.kernel.org, Dongsheng Yang <dongsheng.yang.linux@...il.com>
Subject: Re: [PATCH 1/7] block: Init for CBD(CXL Block Device)



在 2024/4/23 星期二 上午 2:39, Randy Dunlap 写道:
> Hi,
> 
> On 4/22/24 12:16 AM, Dongsheng Yang wrote:
>> diff --git a/drivers/block/cbd/Kconfig b/drivers/block/cbd/Kconfig
>> new file mode 100644
>> index 000000000000..98b2cbcdf895
>> --- /dev/null
>> +++ b/drivers/block/cbd/Kconfig
>> @@ -0,0 +1,4 @@
>> +config BLK_DEV_CBD
>> +	tristate "CXL Block Device"
>> +	help
>> +	  If unsure say 'm'.
> 
> I think that needs more help text. checkpatch should have said something
> about that...
> 
> And why should someone say 'm' to the config question?
> Will lots of (non-server) computers have CXL block device capability?

Hi,
     Thanx for your review! In this RFC version, I have focused entirely 
on prototype validation and demonstration, so this aspect has evidently 
been overlooked. I will supplement the help text in the next version. Of 
course, this place should be If unsure say "n", not "m".

Thanx
> 
> thanks.
>