linux-kernel - Re: [PATCH v2 1/4] virtio_balloon: separate vm events into a function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a182645-1f7f-4b7d-a16a-36e9b1684c58@redhat.com>
Date: Mon, 22 Apr 2024 09:47:00 +0200
From: David Hildenbrand <david@...hat.com>
To: zhenwei pi <pizhenwei@...edance.com>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, virtualization@...ts.linux.dev
Cc: mst@...hat.com, jasowang@...hat.com, xuanzhuo@...ux.alibaba.com,
 akpm@...ux-foundation.org
Subject: Re: [PATCH v2 1/4] virtio_balloon: separate vm events into a function

On 22.04.24 09:42, zhenwei pi wrote:
> All the VM events related statistics have dependence on
> 'CONFIG_VM_EVENT_COUNTERS', once any stack variable is required by any
> VM events in future, we would have codes like:
>   #ifdef CONFIG_VM_EVENT_COUNTERS
>        unsigned long foo;
>   #endif
>        ...
>   #ifdef CONFIG_VM_EVENT_COUNTERS
>        foo = events[XXX] + events[YYY];
>        update_stat(vb, idx++, VIRTIO_BALLOON_S_XXX, foo);
>   #endif
> 
> Separate vm events into a single function, also remove

Why not simply use __maybe_unused for that variable?

-- 
Cheers,

David / dhildenb