Message-ID: <a27572a5-2f1c-46ff-8528-4cae17c8e5e9@linaro.org>
Date: Mon, 22 Apr 2024 09:50:40 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>, linux-serial@...r.kernel.org,
 linux-kernel@...r.kernel.org, Al Cooper <alcooperx@...il.com>,
 Alexander Shiyan <shc_work@...l.ru>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>, Baruch Siach
 <baruch@...s.co.il>, Bjorn Andersson <andersson@...nel.org>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 "David S. Miller" <davem@...emloft.net>, Fabio Estevam <festevam@...il.com>,
 Hammer Hsieh <hammerh0314@...il.com>,
 Christian König <christian.koenig@....com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Chunyan Zhang <zhang.lyra@...il.com>, Jerome Brunet <jbrunet@...libre.com>,
 Jonathan Hunter <jonathanh@...dia.com>, Kevin Hilman <khilman@...libre.com>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>,
 Laxman Dewangan <ldewangan@...dia.com>,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 "Maciej W. Rozycki" <macro@...am.me.uk>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Michael Ellerman <mpe@...erman.id.au>, Michal Simek <michal.simek@....com>,
 "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Nicholas Piggin <npiggin@...il.com>, Orson Zhai <orsonzhai@...il.com>,
 Pali Rohár <pali@...nel.org>,
 Patrice Chotard <patrice.chotard@...s.st.com>,
 Peter Korsgaard <jacmet@...site.dk>,
 Richard Genoud <richard.genoud@...il.com>,
 Russell King <linux@...linux.org.uk>, Sascha Hauer <s.hauer@...gutronix.de>,
 Shawn Guo <shawnguo@...nel.org>, Stefani Seibold <stefani@...bold.net>,
 Sumit Semwal <sumit.semwal@...aro.org>,
 Taichi Sugaya <sugaya.taichi@...ionext.com>,
 Takao Orito <orito.takao@...ionext.com>,
 Tharun Kumar P <tharunkumar.pasumarthi@...rochip.com>,
 Thierry Reding <thierry.reding@...il.com>, Timur Tabi <timur@...nel.org>,
 Vineet Gupta <vgupta@...nel.org>
Subject: Re: [PATCH 00/15] tty: serial: switch from circ_buf to kfifo

Hi Greg,

On 20/04/2024 07:42, Greg KH wrote:
> On Fri, Apr 19, 2024 at 05:12:28PM +0200, Neil Armstrong wrote:
>> This patchset has at least broken all Amlogic and Qualcomm boards so
>> far, only part of them were fixed in next- but this serie has been
>> merged in v1 with no serious testing and should've been dropped
>> immediately when the first regressions were reported.
> 
> What is not yet fixed with the recent patch that was just sent to the
> list?
> 
> Doing core changes like this is hard, I have seen no lack of willingness
> to fix reported problems or major breakages that would deserve a revert.

It broken all Amlogic and Qualcomm boards, are we sure it didn't break other systems that are not CI tested on -next ?

This serie clearly deserved a v2, patch 11 wasn't seriously reviewed, and it deserved a ping on the RFT before sending a v1.

I don't understand why speeding up this changeset and applying it without any reviews nor tests was so important.

Thanks,
Neil
> 
> greg k-h

Powered by blists - more mailing lists