[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f70d53d2-0494-461d-9cbb-086077324e03@pengutronix.de>
Date: Mon, 22 Apr 2024 10:24:45 +0200
From: Holger Assmann <h.assmann@...gutronix.de>
To: Krzysztof Kozlowski <krzk@...nel.org>, lgirdwood@...il.com,
broonie@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, yibin.gong@....com
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [PATCH 2/2] dt-bindings: regulator: pca9450: add restart handler
priority
Hello Krzysztof,
also thanks for the feedback on this one.
Am 19.04.24 um 15:39 schrieb Krzysztof Kozlowski:
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
Short note: I did that prior submitting, but I did it directly for the
yaml-file and not for the directory - Those do not look the same
regarding their prefix scheme.
I will change it for my v2 and use a subject like for the directory.
>
>> ---
>> .../devicetree/bindings/regulator/nxp,pca9450-regulator.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
>> index 3d469b8e97748..7cc2d6636cf52 100644
>> --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
>> @@ -35,6 +35,9 @@ properties:
>> interrupts:
>> maxItems: 1
>>
>> + priority:
>> + $ref: /schemas/power/reset/restart-handler.yaml#
>
> You defined object, which is not explained in commit msg. This code does
> not look correct or it does not implement what you said.
>
> Please look at existing code - do you see anything like this? No, there
> is no such code and this should raise question.
I am a bit lost on that one to be honest.
The only other instances where a "priority" for restart handling is
described are "gpio-poweroff.yaml" and "syscon-reboot.yaml". These files
are dedicated documentation for the reset bindings, so I tried to
transfer the respective entry over for my commit.
Do you suggest I should replace
+ priority:
+ $ref: /schemas/power/reset/restart-handler.yaml#
with
+allOf:
+ - $ref: /schemas/power/reset/restart-handler.yaml#
in order to properly include the context for the restart handling?
Running dt_binding_check does not indicate an issue with any of those two.
>
> You probably want to annotate that device is a restart handler?
You mean by adding to the "description" part of the file?
Kind regards,
Holger
--
Pengutronix e.K. | Holger Assmann |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists