linux-kernel - Re: [PATCH v1 1/2] media: dt-bindings: i2c: add Giantec GT97xx VCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce03bc0c-b113-44c3-8243-0fa22b8a95bf@kernel.org>
Date: Mon, 22 Apr 2024 05:26:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Zhi Mao <zhi.mao@...iatek.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
 Heiko Stuebner <heiko@...ech.de>, Sakari Ailus
 <sakari.ailus@...ux.intel.com>, Hans Verkuil <hverkuil-cisco@...all.nl>,
 Hans de Goede <hdegoede@...hat.com>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Alain Volmat <alain.volmat@...s.st.com>,
 Paul Elder <paul.elder@...asonboard.com>,
 Mehdi Djait <mehdi.djait@...tlin.com>,
 Andy Shevchenko <andy.shevchenko@...il.com>,
 Bingbu Cao <bingbu.cao@...el.com>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 shengnan.wang@...iatek.com, yaya.chang@...iatek.com, yunkec@...omium.org,
 10572168@...com
Subject: Re: [PATCH v1 1/2] media: dt-bindings: i2c: add Giantec GT97xx VCM

On 20/04/2024 03:18, Zhi Mao wrote:
> Add YAML device tree binding for GT9768 & GT8769 VCM,
> and the relevant MAINTAINERS entries.
> 
> Signed-off-by: Zhi Mao <zhi.mao@...iatek.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

If there is going to be any new version, then:

>  .../bindings/media/i2c/giantec,gt9769.yaml    | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)

> +title: Giantec Semiconductor, Crop. GT9768 & GT9769 Voice Coil Motor (VCM)
> +
> +maintainers:
> +  - Zhi Mao <zhi.mao@...iatek.com>
> +
> +description: |-

Drop |-

> +  The Giantec GT9768 & GT9768 is a 10-bit DAC with current sink capability.
> +  The DAC is controlled via I2C bus that operates at clock rates up to 1MHz.
> +  This chip integrates Advanced Actuator Control (AAC) technology
> +  and is intended for driving voice coil lens in camera modules.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - giantec,gt9768
> +      - giantec,gt9769
> +
> +  reg:
> +    maxItems: 1
> +
> +  vin-supply: true
> +
> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vin-supply
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +

Drop blank line

> +    i2c {



Best regards,
Krzysztof