linux-kernel - Re: [PATCH] arm64: dts: rockchip: move uart2 pinmux to dtsi on rk3588-tiger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97e7c50c-9cfc-4139-8b25-0c1b5b8c9d01@theobroma-systems.com>
Date: Mon, 22 Apr 2024 10:44:01 +0200
From: Quentin Schulz <quentin.schulz@...obroma-systems.com>
To: Heiko Stuebner <heiko@...ech.de>
Cc: linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Heiko Stuebner <heiko.stuebner@...rry.de>
Subject: Re: [PATCH] arm64: dts: rockchip: move uart2 pinmux to dtsi on
 rk3588-tiger

Hi Heiko,

On 4/19/24 10:03, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@...rry.de>
> 
> The association of uart2 to the q7-uart pins is part of the module
> itself and not the baseboard used. Therefore move the pinctrl over
> to the tiger dtsi.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...rry.de>

Could have squeezed in a comment to state that this UART is the UART0 
signals on Q7 because I often have to reopen the schematics/carrierboard 
DTS to remember which uart controller of which SoM is used for the debug 
console :)

In any case,

Reviewed-by: Quentin Schulz <quentin.schulz@...obroma-systems.com>

Thanks,
Quentin