linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: add dual-role usb3 hosts to rk3588 Tiger-Haikou

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74f2bd5b-8e2a-4915-a60b-f4f9d04981a4@theobroma-systems.com>
Date: Mon, 22 Apr 2024 11:06:55 +0200
From: Quentin Schulz <quentin.schulz@...obroma-systems.com>
To: Heiko Stuebner <heiko@...ech.de>
Cc: linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Heiko Stuebner <heiko.stuebner@...rry.de>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add dual-role usb3 hosts to
 rk3588 Tiger-Haikou

Hi Heiko,

On 4/18/24 23:03, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@...rry.de>
> 
> Apart from the host-only usb3 controller (host2) the rk3588 also provides
> two dual-role controllers. On the Tiger-Haikou combination these are
> connected to the lower usb3-host port in host-only mode and the micro-usb3
> port for dual-role operation.
> 
> Add the necessary controllers, phys and usb-id extcon to the Tiger-Haikou
> board. The Q7 standard defines the pin as usb-id, but it will only ever
> get used if the baseboard actually provides an OTG port. So the extcon
> stays disabled in the dtsi and only gets enabled in the haikou dts.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...rry.de>

Would have preferred two separate commits but the content is fine and 
it's not that difficult to review, so

Reviewed-by: Quentin Schulz <quentin.schulz@...obroma-systems.com>

Thanks,
Quentin