linux-kernel - Re: [linux-next:master] [init] b8de39bd1b: BUG:kernel_failed_in_early-boot_stage,last_printk:early_console_in_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZiYrdnbw5z1ajeRw@kernel.org>
Date: Mon, 22 Apr 2024 12:18:46 +0300
From: Mike Rapoport <rppt@...nel.org>
To: Nam Cao <namcao@...utronix.de>
Cc: kernel test robot <oliver.sang@...el.com>, oe-lkp@...ts.linux.dev,
	lkp@...el.com, Linux Memory Management List <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Björn Töpel <bjorn@...nel.org>,
	Andreas Dilger <adilger@...ger.ca>, Arnd Bergmann <arnd@...db.de>,
	Changbin Du <changbin.du@...wei.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Ingo Molnar <mingo@...nel.org>,
	Krister Johansen <kjlx@...pleofstupid.com>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>, Tejun Heo <tj@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [linux-next:master] [init]  b8de39bd1b:
 BUG:kernel_failed_in_early-boot_stage,last_printk:early_console_in_setup_code

On Mon, Apr 22, 2024 at 10:29:42AM +0200, Nam Cao wrote:
> On Mon, Apr 22, 2024 at 03:45:00PM +0800, kernel test robot wrote:
> > kernel test robot noticed "BUG:kernel_failed_in_early-boot_stage,last_printk:early_console_in_setup_code" on:
> > 
> > commit: b8de39bd1b76faffe7cd91e148a6d7d9bf4e38f7 ("init: fix allocated page overlapping with PTR_ERR")
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
> 
> I can reproduce the problem. I rebased this commit onto v6.8.7, I can still
> observe the problem.
> 
> No immediate idea what is the problem. Backtrace from gdb goes crazy:
> 
> (gdb) bt
> #0  0xffffffffb2074ded in ?? ()
> #1  0x00000000000000a1 in ?? ()
> #2  0x00000000000000a1 in ?? ()
> #3  0x000000007ffff000 in ?? ()
> #4  0x00000000543ff000 in ?? ()
> #5  0x0000000000000000 in ?? ()

The kernel config here has CONFIG_DEBUG_VIRTUAL=y, so __pa translates to
__phys_addr() in arch/x86/mm/physaddr.c and __pa(-PAGE_SIZE) triggers

		VIRTUAL_BUG_ON(y >= KERNEL_IMAGE_SIZE);

x86 has __pa_nodebug() that does not do bounds check, but it cannot be used
in generic code because no other arch except s390 define it.

For now I don't have ideas how to make this work in the general case, so
probably we should only fix riscv for now.
 
> @akpm: drop this commit until this is figured out?
> 
> Best regards,
> Nam
> 

-- 
Sincerely yours,
Mike.