linux-kernel - Re: [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D0QK66M6GGD7.2ESAAEDMDOUUO@kernel.org>
Date: Mon, 22 Apr 2024 11:53:35 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Tudor Ambarus" <tudor.ambarus@...aro.org>, "Pratyush Yadav"
 <pratyush@...nel.org>, "Miquel Raynal" <miquel.raynal@...tlin.com>,
 "Richard Weinberger" <richard@....at>, "Vignesh Raghavendra"
 <vigneshr@...com>
Cc: "Ricardo Ribalda" <ribalda@...nel.org>, <linux-kernel@...r.kernel.org>,
 <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info()

Hi,

> 	if (name)
> 		info = spi_nor_match_name(nor, name);
>
> 	if (!info || info->id) {
> 		jinfo = spi_nor_detect(nor);
> 		if (IS_ERR(jinfo))
> 			return jinfo;
> 		
> 		if (jinfo != info)

info could be NULL here. So "info &&", apart from that looks good.

> 			dev_warn(();
> 		info = jinfo;
> 	}

Pratyush, should I'll drop your Rb tag then.

-michael

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)