linux-kernel - Re: [PATCH -next v3 1/2] erofs: get rid of erofs_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d751a33-af11-4aa8-8fad-cc24e825bde7@linux.alibaba.com>
Date: Mon, 22 Apr 2024 18:25:26 +0800
From: Jingbo Xu <jefflexu@...ux.alibaba.com>
To: Baokun Li <libaokun1@...wei.com>, linux-erofs@...ts.ozlabs.org
Cc: xiang@...nel.org, chao@...nel.org, huyue2@...lpad.com,
 viro@...iv.linux.org.uk, brauner@...nel.org, linux-kernel@...r.kernel.org,
 yangerkun@...wei.com, houtao1@...wei.com
Subject: Re: [PATCH -next v3 1/2] erofs: get rid of erofs_fs_context



On 4/19/24 8:36 PM, Baokun Li wrote:

> @@ -761,12 +747,15 @@ static void erofs_free_dev_context(struct erofs_dev_context *devs)
>  
>  static void erofs_fc_free(struct fs_context *fc)
>  {
> -	struct erofs_fs_context *ctx = fc->fs_private;
> +	struct erofs_sb_info *sbi = fc->s_fs_info;
> +
> +	if (!sbi)
> +		return;


This is the only difference comparing to the original code literally.
Is there any chance that fc->s_fs_info can be NULL when erofs_fc_free()
is called?

Otherwise looks good to me.



-- 
Thanks,
Jingbo