linux-kernel - RE: [PATCH v2 0/2] Add adm1281 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <PH0PR03MB6607B80801B186F4E1ADA7F1EC122@PH0PR03MB6607.namprd03.prod.outlook.com>
Date: Mon, 22 Apr 2024 04:09:51 +0000
From: "SanBuenaventura, Jose" <Jose.SanBuenaventura@...log.com>
To: Guenter Roeck <linux@...ck-us.net>, Krzysztof Kozlowski <krzk@...nel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
CC: Jean Delvare <jdelvare@...e.com>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Jonathan
 Corbet <corbet@....net>,
        Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
Subject: RE: [PATCH v2 0/2] Add adm1281 support

> -----Original Message-----
> From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
> Sent: Monday, April 22, 2024 11:45 AM
> To: Krzysztof Kozlowski <krzk@...nel.org>; SanBuenaventura, Jose
> <Jose.SanBuenaventura@...log.com>; linux-hwmon@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> doc@...r.kernel.org; linux-i2c@...r.kernel.org
> Cc: Jean Delvare <jdelvare@...e.com>; Rob Herring <robh@...nel.org>;
> Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; Jonathan Corbet <corbet@....net>; Delphine CC
> Chiu <Delphine_CC_Chiu@...ynn.com>
> Subject: Re: [PATCH v2 0/2] Add adm1281 support
> 
> [External]
> 
> On 4/21/24 20:28, Krzysztof Kozlowski wrote:
> > On 22/04/2024 04:51, Jose Ramon San Buenaventura wrote:
> >> This patch removes the extra case added in the adm1275_read_byte_data
> >> for STATUS_CML reads. Upon checking, the reads for the STATUS_CML
> >> register is already handled in the pmbus_core.
> >>
> >> It was also clarified and agreed upon that any other actionable steps
> >> involving the STATUS_CML error flags should be added in the
> >> pmbus_core and not on the specific chip driver.
> >>
> >
> > Where is the changelog? It's v2, so what happened here?
> >
> 
> Same question.
> 
> Guenter
> 

Hello,

The only change from v1 to v2 is the removal of the additional case
for STATUS_CML in the adm1275_read_byte_data function in the adm1275.c
driver code. No changes were done in the other files, only in the driver code.

I apologize for the confusion.

For clarification, do I need to resend the patches and include a changelog
in the patch that specifies the changes done i.e., v1 -> v2: removed case?

Joram