linux-kernel - Re: [PATCH v3 0/1] Fix lb_imbalance reporting in /proc/schedstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68372695-78d9-4036-8d59-fbf1d1261470@amd.com>
Date: Mon, 22 Apr 2024 16:42:36 +0530
From: Swapnil Sapkal <Swapnil.Sapkal@....com>
To: linux-kernel@...r.kernel.org, mingo@...hat.com
Cc: peterz@...radead.org, torvalds@...ux-foundation.org,
 juri.lelli@...hat.com, dietmar.eggemann@....com, rostedt@...dmis.org,
 mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
 vincent.guittot@...aro.org, gautham.shenoy@....com, sshegde@...ux.ibm.com,
 kprateek.nayak@....com
Subject: Re: [PATCH v3 0/1] Fix lb_imbalance reporting in /proc/schedstat

Hello Ingo,

On 3/18/2024 2:54 PM, Swapnil Sapkal wrote:
> This patch adds new fields to /proc/schdstat. First version of
> the patch is sent here [1]. This patch goes on top of the
> commit d72cf62438d6 ("sched/balancing: Fix a couple of outdated function names in comments")
> from tip/sched/core. This change is intended to be a part of v16 of
> /proc/schedstat.
> 
> v2 --> v3 change:
>    - Incorporated review comment by Shrikanth Hegde
>    - Added reviewed by.
> 
> v1 --> v2 change:
>    - Added links to previous schedstat documentation
>    - Incorporated review comments by Shrikanth Hegde
> 
> Motivation:
> 
> In /proc/schedstat, lb_imbalance reports the sum of imbalances
> discovered in sched domains with each call to sched_balance_rq(), which is
> not very useful because lb_imbalance does not mention whether the imbalance
> is due to load, utilization, nr_tasks or misfit_tasks. Remove this field
> from /proc/schedstat.
> 
> Currently there is no field in /proc/schedstat to report different types
> of imbalances. Introduce new fields in /proc/schedstat to report the
> total imbalances in load, utilization, nr_tasks or misfit_tasks.
> 
> [1] https://lore.kernel.org/lkml/66f1e42c-9035-4f9b-8c77-976ab50638bd@amd.com/
> 
> Swapnil Sapkal (1):
>    sched: Report the different kinds of imbalances in /proc/schedstat
> 
>   Documentation/scheduler/sched-stats.rst | 121 ++++++++++++++----------
>   include/linux/sched/topology.h          |   5 +-
>   kernel/sched/fair.c                     |  21 +++-
>   kernel/sched/stats.c                    |   7 +-
>   4 files changed, 99 insertions(+), 55 deletions(-)
> 
Gentle ping. Can you please consider this for v6.10? If anything needs to be changed please let me know.

Thanks and Regards,
Swapnil