[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZiZcyhoKRgfteO5d@smile.fi.intel.com>
Date: Mon, 22 Apr 2024 15:49:14 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Konstantin Pugin <rilian.la.te@...ru>
Cc: krzk@...nel.org, conor@...nel.org, lkp@...el.com, vz@...ia.com,
robh@...nel.org, jcmvbkbc@...il.com, nicolas.ferre@...rochip.com,
manikanta.guntupalli@....com, corbet@....net, ychuang3@...oton.com,
u.kleine-koenig@...gutronix.de, Maarten.Brock@...ls.nl,
Konstantin Pugin <ria.freelander@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>,
Hugo Villeneuve <hvilleneuve@...onoff.com>,
Lech Perczak <lech.perczak@...lingroup.com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v6 1/3] serial: sc16is7xx: announce support of
SER_RS485_RTS_ON_SEND
On Mon, Apr 22, 2024 at 03:37:55PM +0300, Konstantin Pugin wrote:
> From: Konstantin Pugin <ria.freelander@...il.com>
>
> The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, but
> after the commit 4afeced55baa ("serial: core: fix sanitizing check for
> RTS settings") we always end up with SER_RS485_RTS_AFTER_SEND set and
> always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which
> breaks some hardware using these chips.
LGTM, but I leave it to Hugo for testing and other comments, if any,
as I don't have a HW.
Reviewed-by: Andy Shevchenko <andy@...nel.org>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists