linux-kernel - Re: [PATCH v6 1/3] serial: sc16is7xx: announce support of SER_RS485_RTS_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Apr 2024 16:06:49 +0200
From: Lino Sanfilippo <LinoSanfilippo@....de>
To: "Konstantin P." <ria.freelander@...il.com>,
 Andy Shevchenko <andy@...nel.org>
Cc: Konstantin Pugin <rilian.la.te@...ru>, krzk@...nel.org, conor@...nel.org,
 lkp@...el.com, vz@...ia.com, robh@...nel.org, jcmvbkbc@...il.com,
 nicolas.ferre@...rochip.com, manikanta.guntupalli@....com, corbet@....net,
 ychuang3@...oton.com, u.kleine-koenig@...gutronix.de,
 Maarten.Brock@...ls.nl, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Hugo Villeneuve
 <hvilleneuve@...onoff.com>, Lech Perczak <lech.perczak@...lingroup.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v6 1/3] serial: sc16is7xx: announce support of
 SER_RS485_RTS_ON_SEND

Hi,

On 22.04.24 15:20, Konstantin P. wrote:
> On Mon, Apr 22, 2024 at 3:56 PM Andy Shevchenko <andy@...nel.org> wrote:
>>
>> On Mon, Apr 22, 2024 at 03:37:55PM +0300, Konstantin Pugin wrote:
>>> From: Konstantin Pugin <ria.freelander@...il.com>
>>>
>>> The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, but
>>> after the commit 4afeced55baa ("serial: core: fix sanitizing check for
>>> RTS settings") we always end up with SER_RS485_RTS_AFTER_SEND set and
>>> always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which
>>> breaks some hardware using these chips.
>>
>> LGTM, but I leave it to Hugo for testing and other comments, if any,
>> as I don't have a HW.
>>
>> Reviewed-by: Andy Shevchenko <andy@...nel.org>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>>
>>
>
> Andy, I need to do v7 (because there is a missed fix), but Yandex do
> not allow me to send more mail( So, can it be sent next day?
>

Please add at least the linux-serial mailing list the next time. As far as I am
concerned, I was only aware of this issue because of Andys response which added
linux-serial. Furthermore shouldnt this also got to stable?

Regards,
Lino