linux-kernel - RE: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Apr 2024 14:34:34 +0000
From: Johan Adolfsson <Johan.Adolfsson@...s.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Neil Armstrong
	<neil.armstrong@...aro.org>, Jessica Zhang <quic_jesszhan@...cinc.com>, Sam
 Ravnborg <sam@...nborg.org>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
	Daniel Vetter <daniel@...ll.ch>, Rob Herring <robh+dt@...nel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
	<conor+dt@...nel.org>, Thierry Reding <thierry.reding@...il.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, kernel
	<kernel@...s.com>, Johan Adolfsson <Johan.Adolfsson@...s.com>
Subject: RE: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi



-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> 
Sent: den 19 april 2024 01:05
To: Johan Adolfsson <Johan.Adolfsson@...s.com>; Neil Armstrong <neil.armstrong@...aro.org>; Jessica Zhang <quic_jesszhan@...cinc.com>; Sam Ravnborg <sam@...nborg.org>; Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>; Maxime Ripard <mripard@...nel.org>; Thomas Zimmermann <tzimmermann@...e.de>; David Airlie <airlied@...il.com>; Daniel Vetter <daniel@...ll.ch>; Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley <conor+dt@...nel.org>; Thierry Reding <thierry.reding@...il.com>
Cc: dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; kernel <kernel@...s.com>
Subject: Re: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi

>On 18/04/2024 16:01, Johan Adolfsson wrote:
>> panel-dsi is similar to panel-dpi with overridable timings
>
>???

I guess a more correct description would be 
"panel-dsi is a fallback in a similar way that panel-dpi is in panel-dpi.yaml .."?

...
>> a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yam
>> l
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi
>> +++ .yaml
>> @@ -56,6 +56,8 @@ properties:
>>        - samsung,sofef00
>>          # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT LCD panel
>>        - tdo,tl070wsh30
>> +        # Generic dsi panel with timing overridable
>> +      - panel-dsi
>
>? Devices are not generic. This is very confusing and commit msg does not help me. Compatibles *must* be specific, see writing-bindings.

I guess I see this a generic fallback, that handles any dsi panel as long as the correct timing etc is specified in devictree, similar to what panel-dpi is in panel-dpi.yaml
Maybe phrasing it similar to panel-dpi.yaml is better?

>Best regards,
>Krzysztof

Best regards
/Johan