linux-kernel - Re: [PATCH v1] mm/huge_memory: improve split_huge_page_to_list_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2EA1EAC6-D42B-4EA8-A919-FD891B2B8AAF@nvidia.com>
Date: Mon, 22 Apr 2024 10:21:26 -0400
From: Zi Yan <ziy@...dia.com>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 John Hubbard <jhubbard@...dia.com>, Matthew Wilcox <willy@...radead.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>
Subject: Re: [PATCH v1] mm/huge_memory: improve
 split_huge_page_to_list_to_order() return value documentation

On 18 Apr 2024, at 11:18, David Hildenbrand wrote:

> The documentation is wrong and relying on it almost resulted in BUGs
> in new callers: we return -EAGAIN on unexpected folio references, not
> -EBUSY.

+Baolin

The code was changed at the commit fd4a7ac32918 ("mm: migrate: try again
if THP split is failed due to page refcnt") without changing the comment.

>
> Let's fix that and also document which other return values we can
> currently see and why they could happen.
>
> Cc: John Hubbard <jhubbard@...dia.com>
> Cc: Zi Yan <ziy@...dia.com>
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: David Hildenbrand <david@...hat.com>
> ---
>  mm/huge_memory.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)

The changes look good to me. Thanks. Reviewed-by: Zi Yan <ziy@...dia.com>

--
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)