linux-kernel - Re: [PATCH net-next v2 2/3] net: pse-pd: pse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Apr 2024 17:02:18 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: "Kory Maincent (Dent Project)" <kory.maincent@...tlin.com>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew@...n.ch>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kyle Swenson <kyle.swenson@....tech>
Subject: Re: [PATCH net-next v2 2/3] net: pse-pd: pse_core: Fix pse regulator
 type

Mon, Apr 22, 2024 at 03:35:47PM CEST, kory.maincent@...tlin.com wrote:
>From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
>
>Clarify PSE regulator as voltage regulator, not current.
>The PSE (Power Sourcing Equipment) regulator is defined as a voltage
>regulator, maintaining fixed voltage while accommodating varying current.
>
>Reviewed-by: Andrew Lunn <andrew@...n.ch>
>Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>

This looks like a fix. Can you provide "Fixes" tag please and perhaps
send this to -net tree?

Thanks!

>---
> drivers/net/pse-pd/pse_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
>index bad29eaa4d01..795ab264eaf2 100644
>--- a/drivers/net/pse-pd/pse_core.c
>+++ b/drivers/net/pse-pd/pse_core.c
>@@ -294,7 +294,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
> 	 */
> 	rdesc->id = id;
> 	rdesc->name = name;
>-	rdesc->type = REGULATOR_CURRENT;
>+	rdesc->type = REGULATOR_VOLTAGE;
> 	rdesc->ops = &pse_pi_ops;
> 	rdesc->owner = pcdev->owner;
> 
>
>-- 
>2.34.1
>
>