[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240423130820.43824-2-ilpo.jarvinen@linux.intel.com>
Date: Tue, 23 Apr 2024 16:08:20 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Bjorn Helgaas <bhelgaas@...gle.com>,
linux-pci@...r.kernel.org,
"Maciej W. Rozycki" <macro@...am.me.uk>,
linux-kernel@...r.kernel.org
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: [PATCH v2 2/2] PCI: Small clarification to the intent of LT wait
Make a small clarification into the comment relating to the LT wait and
the purpose of the check that implements the implementation note in
PCIe r6.1 sec 7.5.3.7.
Suggested-by: Maciej W. Rozycki <macro@...am.me.uk>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
---
v2:
- New patch
---
drivers/pci/pci.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 70b8c87055cb..5a25facb3ce7 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4625,9 +4625,10 @@ int pcie_retrain_link(struct pci_dev *pdev, bool use_lt)
/*
* Ensure the updated LNKCTL parameters are used during link
- * training by checking that there is no ongoing link training to
- * avoid LTSSM race as recommended in Implementation Note at the
- * end of PCIe r6.0.1 sec 7.5.3.7.
+ * training by checking that there is no ongoing link training that
+ * may have started before link parameters were changed, so as to
+ * avoid LTSSM race as recommended in Implementation Note at the end
+ * of PCIe r6.1 sec 7.5.3.7.
*/
rc = pcie_wait_for_link_status(pdev, true, false);
if (rc)
--
2.39.2
Powered by blists - more mailing lists